phoebus-setup-hook: add java heap size and change encoding by default for phoebus #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minijackson
reviewed
Jun 5, 2024
|
Can you also rename your commit to |
Rider128
changed the title
added 2 commits
November 7, 2024 09:15
The wrapper was added for edit JAVA_OPTS in options.
Rider128
force-pushed
the
default-option-phoebus
branch
from
d4a55fd to
53ae6af
Compare
Add the possibility to enable phoebus in a nixos configuration Add the possibility to edit java_opts
minijackson
reviewed
Nov 7, 2024
Rider128
force-pushed
the
default-option-phoebus
branch
from
53ae6af to
da863ca
Compare
minijackson
requested changes
Nov 7, 2024
minijackson
reviewed
Nov 27, 2024
minijackson
requested changes
Dec 10, 2024
Rider128
commented
Dec 12, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
minijackson
reviewed
Dec 13, 2024
|
|
||
| # This wrapper for the `phoebus-unwrapped` executable sets the `JAVA_OPTS` | ||
| makeWrapper "${lib.getExe epnix.phoebus-unwrapped}" "$out/bin/$pname" \ | ||
| --prefix JAVA_OPTS ":" "${java_opts}" |
There was a problem hiding this comment.
JAVA_OPTS is a variable separated by spaces (instead of :). Found this by looking at the generated wrapper script, and saw that it weirdly split the ${java_opts} by :. I don't know if this could lead to issues, but let's not take that risk.
Suggested change
| --prefix JAVA_OPTS ":" "${java_opts}" | |
| --prefix JAVA_OPTS " " "${java_opts}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.